Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes toolbar buttons stealing focus from editor. #956

Merged
merged 1 commit into from
Sep 17, 2022
Merged

Fixes toolbar buttons stealing focus from editor. #956

merged 1 commit into from
Sep 17, 2022

Conversation

Blquinn
Copy link
Contributor

@Blquinn Blquinn commented Sep 17, 2022 •
edited
Loading

ISSUE: 955

I think another decent option would be to simply pass the FocusNode to the buttons instead of having this callback.

singerdmx
singerdmx requested changes Sep 17, 2022
View reviewed changes
Copy link
Owner

@singerdmx singerdmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update gitignore for vscode

@singerdmx singerdmx merged commit ab6174d into singerdmx:master Sep 17, 2022
@Blquinn
Copy link
Contributor Author

Blquinn commented Sep 17, 2022

I was fixing the gitignore... Did you mean to merge that?

@singerdmx
Copy link
Owner

It is fine

@Blquinn
Copy link
Contributor Author

Blquinn commented Sep 17, 2022

Ok 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@singerdmx singerdmx singerdmx requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Blquinn @singerdmx