Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose (TL;DR) - mandatory
Support callable instances
Closes #2516
Background (Problem in detail)
Enables testing constructors that return functions. #2516 has further description.
Solution - optional
The constructor return value seems to be checked in
proxy-invoke.js
. This expands thetypeof
check to include functions.This works for my code in a local patched version. Tests are included to verify.
How to verify - mandatory
npm install
npm test
You can verify manually by running this code from the checkout root. Output should be
true
.Checklist for author
npm run lint
passes