Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customizable text inputs in the fields #4

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dustedrob
Copy link

Thanks for creating this library. I added some extra options to make it more customizable.

Added Java 8 compatibility
Updated support library
Fixed code maturity inspections

SignupFragment and LoginFragment textInputs are now customizable

Added Java 8 compatibility
Updated support library
Fixed code maturity inspections

SignupFragment and LoginFragment textInputs are now customizable
@@ -12,10 +12,22 @@ Almost every app has a login and signup, so why do we re-write code everytime? L
![login](https://raw.githubusercontent.com/sirvar/robin/master/assets/login.png) ![signup](https://raw.githubusercontent.com/sirvar/robin/master/assets/signup.png)

# Usage
Add this to your **build.gradle**
Add it in your root build.gradle at the end of repositories:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't add instructions for your own hosted artifact to the README

return !(email.getText().toString().isEmpty() || password.getText().toString().isEmpty());


for( int i = 0; i < layout.getChildCount(); i++ ) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the formatting here to match the rest of the code base. Open brace on same line and fix spacing on for( int i = 0; i < layout.getChildCount(); i++ ) {

* can modify it's fields and components
* @param signupFragment
*/
public void onSignupFragmentCreated(SignupFragment signupFragment)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open brace on same line

* can modify it's fields and components
* @param loginFragment
*/
public void onLoginFragmentCreated(LoginFragment loginFragment)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open brace on same line

return (!(name.getText().toString().isEmpty() || email.getText().toString().isEmpty() || password.getText().toString().isEmpty()) && (password.getText().toString().equals(confirmPassword.getText().toString())));


for( int i = 0; i < layout.getChildCount(); i++ ) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix formatting here to match codebase.

* @param visibility .- The {@link android.view.View} Visibility for this field
* @param hint .- The hint for this Field. Will use default if null
*/
public void setEmailField(int visibility, @Nullable String hint)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open braces on same line

* @param visibility .- The {@link android.view.View} Visibility for this field
* @param hint .- The hint for this Field. Will use default if null
*/
public void setNameField(int visibility, @Nullable String hint)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open braces on same line

* @param visibility .- The {@link android.view.View} Visibility for this field
* @param hint .- The hint for this Field. Will use default if null
*/
public void setPasswordField(int visibility, @Nullable String hint)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open braces on same line

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants