Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

html report visualmetrics times overlap #2761

Closed
matti opened this issue Nov 7, 2019 · 22 comments · Fixed by #4269
Closed

html report visualmetrics times overlap #2761

matti opened this issue Nov 7, 2019 · 22 comments · Fixed by #4269

Comments

@matti
Copy link

matti commented Nov 7, 2019

adf

@matti
Copy link
Author

matti commented Nov 7, 2019

@samulir will prob submit a PR soon

@ExplorerAadi
Copy link

Hi,
I would like to take this issue if it isn't fixed yet or noone is still working on it ?

@matti
Copy link
Author

matti commented Oct 2, 2020

no, go ahead

@ExplorerAadi
Copy link

sorry, picked other open source and got hands full. Don't mind.

@matti
Copy link
Author

matti commented Oct 4, 2020 via email

@schambers
Copy link

schambers commented Oct 13, 2021

I'd like to take this if no one else has yet. Looks pretty easy.

One question to verify my changes locally, is there instructions on deploying docker locally so I don't have to install ffmpeg on osx?

Second question is it seems acceptable to rotate the x axis labels by 45 degrees. Are updates made in the sass files directly?

@matti
Copy link
Author

matti commented Oct 13, 2021 via email

@soulgalore
Copy link
Member

Hi @schambers I think these are the ones you need: https://docs.docker.com/desktop/mac/install/

To get the videos to work on Mac there are a couple of more things you need: https://www.sitespeed.io/documentation/sitespeed.io/installation/#mac

Let me know if you need any help!

@schambers
Copy link

So I got sidetracked and was having difficulty with my laptop. I wont have time to work on this and someone else can grab it. Thanks for the help!

@DevilsAutumn
Copy link
Contributor

i would like to work on it ,if its available.

@matti
Copy link
Author

matti commented Feb 7, 2022

#2761 (comment)

@soulgalore soulgalore removed the prio:5 label Feb 12, 2022
@SD007CSE
Copy link

is this issue available?

@matti
Copy link
Author

matti commented Feb 20, 2023

@SD007CSE most definitely! and based on the history it will be available until 2029!

@shaikhazrath
Copy link

i want to fix this can i know how to reproduce the same issue

@soulgalore
Copy link
Member

@shaikhazrath I think it happens if you test a really slow web site. You can slowdown the connectivity to use 3g and then run your test, maybe that can reproduce it.

@matti
Copy link
Author

matti commented May 11, 2023

is there some reward on sitespeed issue fixing somewhere? just looking at the history of this issue and it seems so

@shaikhazrath
Copy link

shaikhazrath commented May 11, 2023

i may not fix it but i want to fix some bugs in sitespeed can anyone guide me "new to open source"

@4nshuman
Copy link
Contributor

4nshuman commented Sep 8, 2024

Hello there @matti,
I am next in line to try and slay this dragon that has claimed so many of our great warriors.
I have analyzed the issue and have determined that this dragon named pug is plotting a chart of destruction with huge numbers.
Allow me to tame this pug and have it plot the numbers at a 45° angle.

@matti
Copy link
Author

matti commented Sep 8, 2024

@4nshuman godspeed

@4nshuman
Copy link
Contributor

4nshuman commented Sep 8, 2024

Hello @matti, @soulgalore
I think I was able to solve this issue:

Before :
image

After :
image

would love to hear your reviews on the PR please.
PR : #4269

@soulgalore
Copy link
Member

Releasing this later today.

@matti
Copy link
Author

matti commented Sep 11, 2024

Thank you @4nshuman @shaikhazrath @SD007CSE @DevilsAutumn @schambers @ExplorerAadi, it has been a pleasure working with you over all these years.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants