Add maxsplit value in QualifiedName retrieval (Instagram#312)

Maxsplit value to account for repeated letters in a QualifiedName
sk- · Jun 11, 2020 · cc7bb9d · cc7bb9d
1 parent dbcb5be
commit cc7bb9d
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 1 deletion.
diff --git a/libcst/metadata/scope_provider.py b/libcst/metadata/scope_provider.py
@@ -248,7 +248,7 @@ def find_qualified_name_for_import_alike(
                         if eval_alias is not None:
                             as_name = eval_alias
                     if full_name.startswith(as_name):
-                        remaining_name = full_name.split(as_name)[1].lstrip(".")
+                        remaining_name = full_name.split(as_name, 1)[1].lstrip(".")
                         results.add(
                             QualifiedName(
                                 f"{real_name}.{remaining_name}"

diff --git a/libcst/metadata/tests/test_qualified_name_provider.py b/libcst/metadata/tests/test_qualified_name_provider.py
@@ -264,3 +264,27 @@ def test_name_in_attribute(self) -> None:
         )
         eval = attr.attr
         self.assertEqual(names[eval], set())
+
+    def test_repeated_values_in_qualified_name(self) -> None:
+        m, names = get_qualified_name_metadata_provider(
+            """
+            import a
+            class Foo:
+                bar: a.aa.aaa
+            """
+        )
+        foo = ensure_type(m.body[1], cst.ClassDef)
+        bar = ensure_type(
+            ensure_type(
+                ensure_type(foo.body, cst.IndentedBlock).body[0],
+                cst.SimpleStatementLine,
+            ).body[0],
+            cst.AnnAssign,
+        )
+
+        annotation = ensure_type(bar.annotation, cst.Annotation)
+        attribute = ensure_type(annotation.annotation, cst.Attribute)
+
+        self.assertEqual(
+            names[attribute], {QualifiedName("a.aa.aaa", QualifiedNameSource.IMPORT)}
+        )