Skip to content

Commit

Permalink
[ENH] move tests for dependency checks and deep_equals to utils m…
Browse files Browse the repository at this point in the history
…odule (#217)

This PR moves the tests for dependency checks and `deep_equals` to the `utils` module where those utilities reside.
  • Loading branch information
fkiraly authored Aug 26, 2023
1 parent d840e75 commit cd7bec6
Show file tree
Hide file tree
Showing 6 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion skbase/testing/test_all_objects.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@
from skbase.testing.utils._conditional_fixtures import (
create_conditional_fixtures_and_names,
)
from skbase.testing.utils._dependencies import _check_soft_dependencies
from skbase.testing.utils.inspect import _get_args
from skbase.utils.deep_equals import deep_equals
from skbase.utils.dependencies import _check_soft_dependencies

__author__: List[str] = ["fkiraly"]

Expand Down
2 changes: 0 additions & 2 deletions skbase/testing/utils/tests/__init__.py

This file was deleted.

2 changes: 1 addition & 1 deletion skbase/tests/test_base.py
Original file line number Diff line number Diff line change
Expand Up @@ -77,9 +77,9 @@
import scipy.sparse as sp

from skbase.base import BaseEstimator, BaseObject
from skbase.testing.utils._dependencies import _check_soft_dependencies
from skbase.tests.conftest import Child, Parent
from skbase.tests.mock_package.test_mock_package import CompositionDummy
from skbase.utils.dependencies import _check_soft_dependencies


# TODO: Determine if we need to add sklearn style test of
Expand Down
2 changes: 2 additions & 0 deletions skbase/utils/dependencies/tests/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
# -*- coding: utf-8 -*-
"""Testing utilities for depeendency checkers."""
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import pytest
from packaging.requirements import InvalidRequirement

from skbase.testing.utils._dependencies import _check_soft_dependencies
from skbase.utils.dependencies._dependencies import _check_soft_dependencies


def test_check_soft_deps():
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
import numpy as np
import pytest

from skbase.testing.utils._dependencies import _check_soft_dependencies
from skbase.utils.deep_equals import deep_equals
from skbase.utils.dependencies import _check_soft_dependencies

# examples used for comparison below
EXAMPLES = [
Expand Down

0 comments on commit cd7bec6

Please sign in to comment.