-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pre-commit.ci] pre-commit autoupdate #205
Conversation
c9e6d2f
to
fcdf553
Compare
any idea why this is failing, @yarnabrina? |
Sorry, not familiar with pre-commit CI, and a bit confused what extra it's supposed to do if it's run in code-quality job. The only thing slightly odd I see in the config is this:
I never ever used it, and unsure if it's affecting anything here. So, can't help :( |
@fkiraly Just have one more curiosity, why do we need to skip Also, I failed to find |
No idea, I was just dealing with what's there, with a conservative approach of not changing both the content and the formatting at the same time.
Yes, you are right. How strange. |
well, pre-commit is happy with this, but now the windows CI is failing: |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #205 +/- ##
=======================================
Coverage 82.41% 82.41%
=======================================
Files 43 43
Lines 2832 2832
=======================================
Hits 2334 2334
Misses 498 498 |
In #205, `pre-commit` CI seems to complain that the `extend-exclude` parameter is not followed by a string (but a list of strings). Attempting to fix this by changing the list of strings into a single string tha should hopefully comply with the expected syntax.
updates: - [github.com/psf/black: 23.3.0 → 23.7.0](psf/black@23.3.0...23.7.0) - [github.com/asottile/blacken-docs: 1.14.0 → 1.15.0](adamchainz/blacken-docs@1.14.0...1.15.0) - [github.com/pycqa/flake8: 6.0.0 → 6.1.0](PyCQA/flake8@6.0.0...6.1.0)
08d60c2
to
1803459
Compare
Fixes a single precommit linting issue from the new pre-commit versions in PR #205
updates: