Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pre-commit.ci] pre-commit autoupdate #205

Merged
merged 2 commits into from
Aug 2, 2023
Merged

Conversation

pre-commit-ci[bot]
Copy link
Contributor

@pre-commit-ci pre-commit-ci bot commented Jul 11, 2023

@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from c9e6d2f to fcdf553 Compare July 11, 2023 07:20
@fkiraly
Copy link
Contributor

fkiraly commented Jul 12, 2023

any idea why this is failing, @yarnabrina?

@yarnabrina
Copy link
Member

Sorry, not familiar with pre-commit CI, and a bit confused what extra it's supposed to do if it's run in code-quality job.

The only thing slightly odd I see in the config is this:

language_version: python3

I never ever used it, and unsure if it's affecting anything here. So, can't help :(

@yarnabrina
Copy link
Member

@fkiraly Just have one more curiosity, why do we need to skip setup.py and conf.py? Do they behave differently in any expect if formatted by black?

Also, I failed to find setup.py file in the repo root. skbase is using pyproject.toml as far as I can see.

@fkiraly
Copy link
Contributor

fkiraly commented Jul 13, 2023

@fkiraly Just have one more curiosity, why do we need to skip setup.py and conf.py? Do they behave differently in any expect if formatted by black?

No idea, I was just dealing with what's there, with a conservative approach of not changing both the content and the formatting at the same time.

Also, I failed to find setup.py file in the repo root. skbase is using pyproject.toml as far as I can see.

Yes, you are right. How strange.

@fkiraly
Copy link
Contributor

fkiraly commented Jul 13, 2023

well, pre-commit is happy with this, but now the windows CI is failing:
#207

@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2023

Codecov Report

Merging #205 (7a92b65) into main (26b7378) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main     #205   +/-   ##
=======================================
  Coverage   82.41%   82.41%           
=======================================
  Files          43       43           
  Lines        2832     2832           
=======================================
  Hits         2334     2334           
  Misses        498      498           

fkiraly added a commit that referenced this pull request Jul 13, 2023
In #205, `pre-commit` CI seems to
complain that the `extend-exclude` parameter is not followed by a string
(but a list of strings).

Attempting to fix this by changing the list of strings into a single
string tha should hopefully comply with the expected syntax.
updates:
- [github.com/psf/black: 23.3.0 → 23.7.0](psf/black@23.3.0...23.7.0)
- [github.com/asottile/blacken-docs: 1.14.0 → 1.15.0](adamchainz/blacken-docs@1.14.0...1.15.0)
- [github.com/pycqa/flake8: 6.0.0 → 6.1.0](PyCQA/flake8@6.0.0...6.1.0)
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 08d60c2 to 1803459 Compare August 1, 2023 09:19
fkiraly added a commit that referenced this pull request Aug 1, 2023
Fixes a single precommit linting issue from the new pre-commit versions
in PR #205
@fkiraly fkiraly merged commit e83bcf0 into main Aug 2, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants