Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] _HeterogenousMetaObject to accept list of tuples of any length #206

Merged
merged 8 commits into from
Aug 14, 2023

Conversation

fkiraly
Copy link
Contributor

@fkiraly fkiraly commented Jul 12, 2023

Mirror PR of sktime/sktime#4793 from sktime.

This improves the _HeterogenousMetaObject by widening its functionality.

_HeterogenousMetaObject now allows tuples of any length in the _steps_attr, as long as the zeroth elements are str names, and the first elements are estimators

@fkiraly fkiraly added the implementing framework Implementing core skbase framework label Jul 12, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2023

Codecov Report

Merging #206 (7657012) into main (9fbe066) will increase coverage by 1.18%.
Report is 1 commits behind head on main.
The diff coverage is 28.57%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #206      +/-   ##
==========================================
+ Coverage   82.42%   83.60%   +1.18%     
==========================================
  Files          43       43              
  Lines        2833     2836       +3     
==========================================
+ Hits         2335     2371      +36     
+ Misses        498      465      -33     
Files Changed Coverage Δ
skbase/base/_meta.py 34.56% <28.57%> (+16.33%) ⬆️

@fkiraly fkiraly marked this pull request as ready for review August 13, 2023 14:58
skbase/tests/test_meta.py Dismissed Show dismissed Hide dismissed
skbase/tests/test_meta.py Fixed Show resolved Hide resolved
@fkiraly fkiraly merged commit 9210fdb into main Aug 14, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
implementing framework Implementing core skbase framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants