& yarnabrina [ENH] prevent imports in _check_soft_dependencies
#340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkiraly
added
implementing framework
fkiraly
changed the title
_check_soft_dependencies_check_soft_dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
_check_soft_dependenciesutility had inefficiencies and side effects, because to check the soft dependency being present, an import would be attempted, which can lead to circular imports or casacding imports.This PR replaces the logic with an import-free check.
It also deprecates the argument
suppress_import_stdout, as there is no longer any import, hence nostdoutoutput that would be created.Mirror of sktime/sktime#6355 which includes contributions by @yarnabrina, and of sktime/sktime#6719