Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] merge sktime BaseEstimator into skbase BaseEstimator #370

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

fkiraly
Copy link
Contributor

@fkiraly fkiraly commented Oct 1, 2024

This merges some minor improvements from sktime BaseEstimator into skbase BaseEstimator:

  • docstring formatting
  • clearer error messages
  • deduplicating logic with check_is_fitted calls

Accompanies sktime/sktime#7213, see there for explanation of merge and deduplication.

@fkiraly fkiraly added the documentation Documentation & tutorials label Oct 1, 2024
@fkiraly fkiraly changed the title [DOC] merge sktime BaseEstimator into skbase BaseEstimator [ENH] merge sktime BaseEstimator into skbase BaseEstimator Oct 1, 2024
@fkiraly fkiraly added the enhancement Adding new functionality label Oct 1, 2024
@fkiraly fkiraly merged commit c71dfe8 into main Oct 4, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation & tutorials enhancement Adding new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant