Fix limit for history stack size (#1001)

slab · Sep 23, 2016 · 2339778 · 2339778
1 parent 47993e5
commit 2339778
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/modules/history.js b/modules/history.js
@@ -58,7 +58,7 @@ class History extends Module {
       undo: undoDelta
     });
     if (this.stack.undo.length > this.options.maxStack) {
-      this.stack.undo.unshift();
+      this.stack.undo.shift();
     }
   }
 

diff --git a/test/unit/modules/history.js b/test/unit/modules/history.js
@@ -67,6 +67,17 @@ describe('History', function() {
       this.original = this.quill.getContents();
     });
 
+    it('limits undo stack size', function () {
+      let quill = new Quill(this.container.firstChild, {
+        modules: {
+          history: {delay: 0, maxStack: 2}
+        }
+      });
+
+      ['A', 'B', 'C'].forEach(text => quill.insertText(0, text));
+      expect(quill.history.stack.undo.length).toEqual(2);
+    });
+
     it('user change', function() {
       this.quill.root.firstChild.innerHTML = 'The lazy foxes';
       this.quill.update();