Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safari autocorrect behavior #565

Closed
quentez opened this issue Jan 19, 2016 · 2 comments
Closed

Safari autocorrect behavior #565

quentez opened this issue Jan 19, 2016 · 2 comments

Comments

@quentez
Copy link
Contributor

quentez commented Jan 19, 2016

The usual autocorrect behavior in Safari is to replace a misspelled word automatically the first time, and then leave it alone if you go back and revert the change.

With Quill, the behavior is different. Even after going back and reverting the autocorrected word, it will be autocorrected again and again, which can be pretty infuriating when trying to write words that don't exist in the dictionary.

I'm suspecting this may be because of how Quill regenerates parts of the DOM every time unlike a traditional contenteditable, which would prevent the browser from tracking what words were autocorrected already. But that's just me speculating.

@quentez quentez changed the title OSX autocorrect behavior Safari autocorrect behavior Jan 19, 2016
@chinshr
Copy link

chinshr commented Jan 21, 2016

Can anyone reproduce this problem?

On Jan 19, 2016, at 11:35 AM, Quentin Calvez notifications@github.com wrote:

The usual autocorrect behavior on OSX (in both Safari and Chrome at least), is to replace a misspelled word automatically the first time, and then leave it alone if you go back and revert the change.

With Quill, the behavior is different. Even after going back and reverting the autocorrected word, it will be autocorrected again and again, which can be pretty infuriating when trying to write words that don't exist in the dictionary.

I'm suspecting this may be because of how Quill regenerates parts of the DOM every time unlike a traditional contenteditable, which would prevent the browser from tracking what words were autocorrected already. But that's just me speculating.


Reply to this email directly or view it on GitHub.

@jhchen
Copy link
Member

jhchen commented Jan 21, 2016

I am able to reproduce this in desktop safari but not mobile. Specifically on the quilljs.com homepage:

  1. Set the cursor on the line right above the "fast and lightweight" bullet
  2. Type "fast and lighta"
  3. Hit space and Safari will correct "lighta" to "lights"
  4. Backspace twice and enter "a" and space again and Safari will continue to correct "lighta" into "lights"

The two workarounds right now are to either continue typing at least one non-whitespace character before correcting the spellchecked word or to disable to checker altogether by setting the spellcheck attribute to false in the Quill editor div.

jhchen added a commit that referenced this issue May 12, 2016
@jhchen jhchen closed this as completed May 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants