Prevent code-token attribute in deltas #2259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhchen
reviewed
Aug 20, 2018
blots/block.js
Outdated
| if (typeof blot.formats === 'function') { | ||
| if ( | ||
| typeof blot.formats === 'function' && | ||
| blot.statics.blotName !== 'code-token' |
There was a problem hiding this comment.
It is possible for the code token blot to have attributes which may have desirable formats to preserve. For example comments are often implemented this way which would produce a blot that looks like:
<span class="ql-token hljs-literal comment-07d9be3c>false</span>
In this case we still do want to call formats() to get the comment format.
|
Ah ok. How about this (updated the code). |
|
👍 |
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2178.
While it feels a bit odd to make a function called
bubbleFormatsalways exclude a particular format from its result, this function could really be called something likecollectFormatsForDelta; it is only called to get the formats for a delta (or the public Quill API,quill.getFormat()).It follows (I believe) that SyntaxCodeBlock no longer needs a custom
delta()method.