Fix cursor top position in multi-cursor module when the quill container is scrolled. #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
is scrolled. Cursors are absolutely positioned with respect to the top of the .ql-container. quill.getBounds().top returns a smaller integer when the .ql-container is scrolled vertically. As a result, positioning a cursor requires adding container.scrollTop to the cursor bounds.
|
Here's a screenshot of the issue reproduced on http://quilljs.com/docs/modules/multi-cursors/ |
jhchen
added a commit
that referenced
this pull request
May 26, 2015
Fix cursor top position in multi-cursor module when the quill container is scrolled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cursors are absolutely positioned with respect to the top of the .ql-container.
quill.getBounds().top returns a smaller integer when the .ql-container is scrolled vertically.
As a result, positioning a cursor requires adding container.scrollTop to the cursor bounds.