Normalize UI node selection #3898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luin
force-pushed
the
zh-ui-selection
branch
6 times, most recently
from
165811b
to
6de005b
Compare
luin
force-pushed
the
zh-ui-selection
branch
3 times, most recently
from
d0e3f48
to
854a75d
Compare
luin
force-pushed
the
zh-ui-selection
branch
2 times, most recently
from
ea08fca
to
c3a7695
Compare
jhchen
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR added a new module to normalize browser's native behavior.
Specifically, in Firefox, when the current line blot contains a UI node, pressing CMD+ArrowLeft in macOS would result in the caret being placed right before the UI node. This PR normalizes the behavior by checking such situations and moving the caret after the UI node.
Test Plan