Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block suggestion in Socket mode #19

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

tsvtitan
Copy link

@tsvtitan tsvtitan commented Aug 5, 2024

In a case of block suggestion which is as a part of block actions, there is no need to send ack as a response. Actually there is a need to send certain response with the same envelope ID

For details: https://api.slack.com/apis/socket-mode#menu

@arusso arusso self-requested a review August 16, 2024 19:29
@arusso
Copy link
Collaborator

arusso commented Aug 16, 2024

re: Acknowledgement -- The link you provided doesn't have a #menu anchor anymore, can you expand on why we don't need to acknowledge the event? I couldn't find anything to suggest that. Is this causing an error or warning you're seeing?

re: Adding the request to the handler -- Could you please submit that as a separate Merge Request? Since we're modifying the interface for users and it is unrelated to changing the acknowledgment behavior, I want that to be it's own MR.

Additionally, could you make sure that each commit is focused solely on the intended change as described in the commit message? This will help avoid any accidental changes creeping in and ensure that our history remains clean and easy to follow.

Finally, please help us out and format commit messages with an accepted prefix per our standard so our release notes can be generated, saving us from having to do manually curate release notes each time we want to cut a release.

Thanks for your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants