Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: exposing request from event in interaction handler in order to Ack event with custom payload #23

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: exposing request from event in interaction handler in order to Ack event with custom payload #23

wants to merge 2 commits into from

Conversation

Vladmel1234
Copy link

this PR addressing #22

@Vladmel1234
Copy link
Author

There is no much sense in first commit without the second one

@raed-shomali
Copy link
Contributor

Would love to get @arusso 's opinion on this PR.

@arusso
Copy link
Collaborator

arusso commented Sep 18, 2024

I'll fix the workflow error, the line length shouldn't prevent progression.

I'll try and look at this later today. I have questions but need to dig in a bit to make sure they're not self explanatory.

@Vladmel1234
Copy link
Author

btw if it is needed to add an example i will happily add one

@raed-shomali
Copy link
Contributor

Examples are always welcome!

@raed-shomali
Copy link
Contributor

@arusso Let us know when you have had the chance to review the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Vladmel1234 @raed-shomali @arusso