optimize: Local variable 'map' is redundant and check queue offer ret…

…urn value (apache#3188)
slievrly · Nov 11, 2020 · 69f341a · 69f341a
1 parent 43f5890
commit 69f341a
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/core/src/main/java/io/seata/core/rpc/netty/AbstractNettyRemotingClient.java b/core/src/main/java/io/seata/core/rpc/netty/AbstractNettyRemotingClient.java
@@ -155,7 +155,11 @@ public Object sendSyncRequest(Object msg) throws TimeoutException {
             // put message into basketMap
             BlockingQueue<RpcMessage> basket = CollectionUtils.computeIfAbsent(basketMap, serverAddress,
                 key -> new LinkedBlockingQueue<>());
-            basket.offer(rpcMessage);
+            if (!basket.offer(rpcMessage)) {
+                LOGGER.error("put message into basketMap offer failed, serverAddress:{},rpcMessage:{}",
+                        serverAddress, rpcMessage);
+                return null;
+            }
             if (LOGGER.isDebugEnabled()) {
                 LOGGER.debug("offer message: {}", rpcMessage.getBody());
             }