Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to override the container image when targeting compose service for minification (--target-compose-svc-image param) #269

Closed
kcq opened this issue Jan 4, 2022 · 4 comments
Closed

Ability to override the container image when targeting compose service for minification (--target-compose-svc-image param) #269

kcq opened this issue Jan 4, 2022 · 4 comments
Labels
enhancement good first issue help wanted

Comments

@kcq
Copy link
Member

kcq commented Jan 4, 2022

You might have a compose file that doesn't reference the exact version of the container image you want to minified (e.g., the target service might reference the latest tag and you want to minify v1.2.3 for your target image).

The --target-compose-svc-image command parameter (for build and profile commands) should provide a way to use the desired image version without having to rewrite your compose file. Need to use the value from the flag instead of the image field from the target service.

This flag is relevant only when the --target-compose-svc and --compose-file parameters are.
@sreeo sreeo mentioned this issue Feb 12, 2022
Merged
@sreeo
Copy link
Contributor

sreeo commented Feb 12, 2022

Can I pick this up?

@kcq
Copy link
Member Author

kcq commented Feb 12, 2022 •
edited
Loading

@sreeo go for for it :)

@sreeo sreeo mentioned this issue Feb 13, 2022
Merged
kcq pushed a commit that referenced this issue Feb 14, 2022
@sreeo
Feature/override container image version #269 (#287)
a9e0307 
* add target-compose-svc-image flag to override dockerimage version in compose during build

* add target image version in command flag suggestion

* Update image with updated tag before build

add unit test for UpdateImage func

* remove UpdateImage func from third_party module

Co-authored-by: sree <sree@srees-MacBook-Air.local>
@mritunjaysharma394
Copy link
Contributor

i think the above PR as fixed this issue, can we close this @kcq?

@kcq
Copy link
Member Author

kcq commented Mar 1, 2022

yes

@kcq kcq closed this as completed Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kcq @sreeo @mritunjaysharma394