core: A small step to better popup placement #6434
Conversation
|
This is what the combobox at the very bottom of the Propert Editor looks now with this patch applied:
not nice, but at least usable! |
internal/core/window/popup.rs
Outdated
| /// Find a placement for the `Popup`, using the provided `Placement`. | ||
| /// When a `clip_region` is provided, then the `Popup` will stay within those bounds. | ||
| /// The `clip_region` typically is the window or the screen the window is on. | ||
| pub fn place_popup(placement: Placement, clip_region: &Option<LogicalRect>) -> Option<LogicalRect> { |
There was a problem hiding this comment.
What does it mean for this function to return None ?
There was a problem hiding this comment.
The current code is a bit limited, that Option in the return value is not used yet. I can remove it again for this initial patch.
I will need to pass min/pref/max sizes of the popup to the placement function. Once I do that, the code can end up in a situation where I can not place the popup at all. E.g. if our window is 200x200px, we need to render into the window surface itself and the popup has a minimum size of 300x300px. There is no way to render that popup fully, so I need to report that somehow.
I was considering using a Result instead, but there is no meaningful way to report that to a user, so a Option should do.
There was a problem hiding this comment.
But what can be done if the popup doesn't fit?
Not showing it at all doesn't seem to be the solution.
There was a problem hiding this comment.
We can have it render centered on its Window maybe?
That might cut off UI elements necessary to dismiss the popup again though, so that is not good either.
hunger
force-pushed
the
tobias/push-xlpylolynwzl
branch
from
2d24524
to
2f0f05c
Compare
|
The latest version got rid of the Option again and might have fixed the build issue in i32 Coords. |
This is the most stupid policy for popup placement that we can possibly implement: If we render the popup as a subsurface in our own window, then just make sure we move to popup so that it does stay fuilly within our own window surface.
hunger
force-pushed
the
tobias/push-xlpylolynwzl
branch
from
2f0f05c
to
4897ebb
Compare
I do not expect this to break things:
IMHO moving a popup is always better than not showing all of it. |
This is the smallest possible improvement we can do for popup placement: Do not render popups outside the surface they can paint on!