Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derive serde for PhysicalPosition, LogicalSize etc. #6551

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

ogoffart
Copy link
Member

Fixes #6534

ChangeLog: [Rust] Derive serde traits for PhysicalPosition, LogicalPosition, PhysicalSize and LogicalSize

Fixes #6534

ChangeLog: [Rust] Derive serde traits for `PhysicalPosition`,
`LogicalPosition`, `PhysicalSize` and `LogicalSize`
Copy link
Member

@tronical tronical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The more I see serde features in library crates, the more I think that this is of such limited use without versioning in place. I wish there was versioning like with QDataStream at least.

@ogoffart ogoffart merged commit 80dfaf8 into master Oct 14, 2024
36 checks passed
@ogoffart ogoffart deleted the olivier/fix-#6534 branch October 14, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make PhysicalPosition, LogicalSize etc. (de)serializable
2 participants