Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider using async_trait #82

Closed
bootrecords opened this issue Jul 29, 2021 · 1 comment · Fixed by #85
Closed

consider using async_trait #82

bootrecords opened this issue Jul 29, 2021 · 1 comment · Fixed by #85

Comments

@bootrecords
Copy link
Contributor

This is more of an internal structuring thing, but I noticed that in many parts of the code base explicit Pin<Box<dyn Future<...>>>s are returned.
While this works, it's a bit tedious to read, so using async-trait may be worth considering for the internal traits, such as Client, Reader and Writer.

@uklotzde
Copy link
Member

I second that.

@flosse flosse mentioned this issue Jul 29, 2021
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants