Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use async_trait #85

Merged
merged 1 commit into from
Aug 12, 2021
Merged

Use async_trait #85

merged 1 commit into from
Aug 12, 2021

Conversation

bootrecords
Copy link
Contributor

First-pass implementation that applies async_trait syntax to the Client, Reader and Writer traits in client/mod.rs as well as to the NewContext trait in client/util.rs.

Note that this leaves the explicit Future generics from the Service trait in server/service.rs untouched and also doesn't introduce async syntax on functions like connect[_slave] in client/tcp.rs, service/tcp.rs and service/rtu.rs. I can still try to work out something there if desired.

Closes #82

Copy link
Member

@uklotzde uklotzde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@uklotzde uklotzde merged commit d1617d9 into slowtec:master Aug 12, 2021
@bootrecords bootrecords deleted the async-trait branch August 12, 2021 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

consider using async_trait
2 participants