Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add vsa e2e #379

Merged
merged 10 commits into from
Jul 23, 2024
Merged

feat: add vsa e2e #379

merged 10 commits into from
Jul 23, 2024

Conversation

ramonpetgrave64
Copy link
Collaborator

@ramonpetgrave64 ramonpetgrave64 commented Jul 22, 2024

followup to slsa-framework/slsa-verifier#777

adds e2e tests for VSAs

Testing

  • I temporarily modified this workflow to also trigger and auto-open and close issues in PRs.
  • edited the script to be able to test failure cases
  • after creating the a new issue laebl "area:vsa" in slsa-framework/slsa-verifier, the workflow did auto-open and aut-close an issue.

example successful run

example failed run

Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
@ramonpetgrave64 ramonpetgrave64 marked this pull request as ready for review July 23, 2024 16:00
@ramonpetgrave64
Copy link
Collaborator Author

@haydentherapper

Copy link

@haydentherapper haydentherapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering, about how long does this take to run, given it's verifying ~3000 VSAs?

declare -a FILE_PATHS
while IFS= read -r file; do
FILE_PATHS+=("$file")
done < <(find ./gke-node-images:238739202978 ./gke-master-images:78064567238 -type f)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be better to search for all intoto.jsonl files, so if they add other top level directories in the future, this script will pick them up?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the time they add support for container images, I suspect they may change the structure of the directories, so I hesitate to simple look for all intoto.jsonl files.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we fail if we find no files, so SG, this should be sufficient and will catch if they make changes in the future.

@ramonpetgrave64
Copy link
Collaborator Author

Just wondering, about how long does this take to run, given it's verifying ~3000 VSAs?

About 38s to run slsa-verifier against all the VSAs, and about 2m for the whole workflow.

declare -a FILE_PATHS
while IFS= read -r file; do
FILE_PATHS+=("$file")
done < <(find ./gke-node-images:238739202978 ./gke-master-images:78064567238 -type f)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we fail if we find no files, so SG, this should be sufficient and will catch if they make changes in the future.

@ramonpetgrave64 ramonpetgrave64 merged commit 0b9eb9b into main Jul 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants