fix: use GITHUB_OUTPUT instead of deprecated set-output command #1061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suzuki-shunsuke
requested review from
asraa,
ianlewis,
laurentsimon and
joshuagl
as code owners
|
Updates #1004 |
|
I thought github.com/sethvargo/go-githubactions is useful because this library has already migrated to GITHUB_OUTPUT in v1.1.0, but I found the proposal was rejected. #153 |
|
Yeah, I think it's a useful library as well but I think we would only be using it for reading the context and setting outputs so it's not really worth adding another dependency. |
|
Yeah, I agree. |
ianlewis
approved these changes
Oct 17, 2022
ianlewis
added a commit
that referenced
this pull request
Oct 21, 2022
Same as #1061 - https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/ - https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#setting-an-output-parameter Co-authored-by: Ian Lewis <ianlewis@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set-outputwas deprecated.AS IS
TO BE