Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add known issues to docs #1170

Merged
merged 7 commits into from
Nov 1, 2022
Merged

Conversation

ianlewis
Copy link
Member

Add a section on known issues to workflow docs.

Signed-off-by: Ian Lewis ianlewis@google.com

Signed-off-by: Ian Lewis <ianlewis@google.com>
Signed-off-by: Ian Lewis <ianlewis@google.com>
@ianlewis ianlewis marked this pull request as ready for review October 27, 2022 08:59
Signed-off-by: Ian Lewis <ianlewis@google.com>
Copy link
Collaborator

@asraa asraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Should we add a note about v1.2.0s issue or is it clear that a patch version supersedes an issue?

This one was the issue with an incompatible change when Rekor sharded, "After Rekor sharded (rotated trees) in production, the tree head no longer corresponds to the same tree that the entry was in, which caused a verification error."

#942

@ianlewis
Copy link
Member Author

Thank you!

Should we add a note about v1.2.0s issue or is it clear that a patch version supersedes an issue?

This one was the issue with an incompatible change when Rekor sharded, "After Rekor sharded (rotated trees) in production, the tree head no longer corresponds to the same tree that the entry was in, which caused a verification error."

#942

I made the note say '1.2.x' in the sub header. AFAICT you currently get the same error for both v1.2.1 and v1.2.0

@ianlewis
Copy link
Member Author

Maybe I can make it clearer what the affected versions are.

Signed-off-by: Ian Lewis <ianlewis@google.com>
@ianlewis ianlewis requested a review from asraa October 27, 2022 22:38
@ianlewis ianlewis self-assigned this Oct 27, 2022
@ianlewis ianlewis enabled auto-merge (squash) November 1, 2022 01:10
@ianlewis ianlewis merged commit b68dcb0 into slsa-framework:main Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants