feat: Support large subjects file in generic generator #2365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurentsimon
changed the title
ianlewis
reviewed
Jul 11, 2023
laurentsimon
force-pushed
the
feat/large-subjects
branch
from
eac8039
to
56550e3
Compare
|
ptal, I addressed the comments |
ianlewis
approved these changes
Jul 18, 2023
laurentsimon
added a commit
to laurentsimon/slsa-github-generator
that referenced
this pull request
Jul 18, 2023
…k#2365) closes slsa-framework#845 --------- Signed-off-by: laurentsimon <laurentsimon@google.com>
This was referenced Jul 19, 2023
laurentsimon
added a commit
that referenced
this pull request
Jul 21, 2023
As part of #2365, we added support for large files. We forgot to update the "success" computation. This means that even though the sha256 may differ from the expected, the job continues and we never record the failure status. I fix this in the PR. I also delete the downloaded folder / artifact if the sha256 don't match, to avoid a similar problem in he future --------- Signed-off-by: laurentsimon <laurentsimon@google.com>
enteraga6
pushed a commit
to enteraga6/slsa-github-generator
that referenced
this pull request
Aug 8, 2023
…k#2365) closes slsa-framework#845 --------- Signed-off-by: laurentsimon <laurentsimon@google.com> Signed-off-by: Noah Elzner <elzner@google.com>
enteraga6
pushed a commit
to enteraga6/slsa-github-generator
that referenced
this pull request
Aug 8, 2023
As part of slsa-framework#2365, we added support for large files. We forgot to update the "success" computation. This means that even though the sha256 may differ from the expected, the job continues and we never record the failure status. I fix this in the PR. I also delete the downloaded folder / artifact if the sha256 don't match, to avoid a similar problem in he future --------- Signed-off-by: laurentsimon <laurentsimon@google.com> Signed-off-by: Noah Elzner <elzner@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #845