Skip to content

Commit

Permalink
typo, clarity
Browse files Browse the repository at this point in the history
  • Loading branch information
ramonpetgrave64 committed Jan 10, 2024
1 parent bcfd751 commit 115489a
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions verifiers/internal/gha/npm_sigstore_tuf.go
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,11 @@ func NewSigstoreTufClient() (*sigstoreTuf.Client, error) {
return client, nil
}

// GetNpmjsKeysTarget Fetch and parse the keys.json file in Sigstore's root for npmjs
// https://github.com/sigstore/root-signing/blob/5fd11f7ec0a993b0f20c335b33e53cfffb986b2e/repository/repository/targets/registry.npmjs.org/7a8ec9678ad824cdccaa7a6dc0961caf8f8df61bc7274189122c123446248426.keys.json#L4
/*
GetNpmjsKeysTarget Fetch and parse the keys.json file in Sigstore's root for npmjs
The inner TUF client will verify this "blob" is signed with correct delegate TUF roles
https://github.com/sigstore/root-signing/blob/5fd11f7ec0a993b0f20c335b33e53cfffb986b2e/repository/repository/targets/registry.npmjs.org/7a8ec9678ad824cdccaa7a6dc0961caf8f8df61bc7274189122c123446248426.keys.json#L4
*/
func GetNpmjsKeysTarget(client SigstoreTufClient, targetPath string) (*NpmjsKeysTarget, error) {
blob, err := client.GetTarget(targetPath)
if err != nil {
Expand All @@ -71,7 +74,7 @@ func GetNpmjsKeysTarget(client SigstoreTufClient, targetPath string) (*NpmjsKeys

/*
GetAttestationKeyMaterialByKeyId Given our set of keys, return the target key's material.
It alse checks that the keyUsage is "nmp:attestations", but we may also want to check
It also checks that the keyUsage is "nmp:attestations", but we may also want to check
the existing ValidFor.Start (and a potential future ValidFor.End).
*/
func GetAttestationKeyMaterialByKeyId(keys *NpmjsKeysTarget, keyId string) (string, error) {
Expand Down

0 comments on commit 115489a

Please sign in to comment.