Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: check entryPoint is non empty for GCB provenance #575

Closed
laurentsimon opened this issue Apr 27, 2023 · 2 comments
Closed

bug: check entryPoint is non empty for GCB provenance #575

laurentsimon opened this issue Apr 27, 2023 · 2 comments
Assignees
@laurentsimon
Labels
area:gcb Issue with the gcb verifier

Comments

@laurentsimon
Copy link
Contributor

GCB allows triggering builds via CLI, in which case the config is passed as an RPC input, but no in code. We should check the entryPoint is not empty.
@laurentsimon laurentsimon added the area:gcb Issue with the gcb verifier label Apr 27, 2023
@laurentsimon laurentsimon self-assigned this Apr 27, 2023
@laurentsimon
Copy link
Contributor Author

I'll wait for #572 to land since it defines new functions to retrieve provenance information, including the entryPoint.

ramonpetgrave64 pushed a commit to ramonpetgrave64/slsa-verifier that referenced this issue Apr 18, 2024
@laurentsimon
update (slsa-framework#575)
eb0e1e8
@ramonpetgrave64
Copy link
Contributor

#572 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@laurentsimon laurentsimon

Labels
area:gcb Issue with the gcb verifier
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ramonpetgrave64 @laurentsimon