test: add builder id tests for short form #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Asra Ali <asraa@google.com>
laurentsimon
approved these changes
Jan 25, 2023
|
Good catch! |
ramonpetgrave64
pushed a commit
to ramonpetgrave64/slsa-verifier
that referenced
this pull request
Apr 18, 2024
* Rename upload-to-release input to upload-assets * Add upload-assets input to doc Co-authored-by: laurentsimon <64505099+laurentsimon@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Asra Ali asraa@google.com
Fixes #440
This adds back in the commented out tests for testing the short form of the builder ID for GHA artifacts and images
builder@TAG. The tests were failing because they setallowRef = false, but for GHA, the builder identity returned is always in long form, meaning that we have to allow the short form matches in the test (which is also done in the code path:slsa-verifier/verifiers/internal/gha/builder.go
Line 105 in 5eea7c5
cc @laurentsimon