Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add docker based spport and start adding tests #486

Merged
merged 1 commit into from
Feb 15, 2023

Conversation

asraa
Copy link
Contributor

@asraa asraa commented Feb 15, 2023

This PR adds the docker-based workflow to the supported trusted builders.

We currently only have main released for it, so I've began by only adding main tests. Follow-up here: #485

This is also gated behind SLSA_VERIFIER_EXPERIMENTAL due to the bundle format, anyway.

Signed-off-by: Asra Ali <asraa@google.com>
Copy link
Contributor

@laurentsimon laurentsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

want to create an issue tracking that the verification will need to be updated to verify @<tag> and not @main?

@laurentsimon
Copy link
Contributor

want to create an issue tracking that the verification will need to be updated to verify @<tag> and not @main?

Ignore the comment, just saw the existing issue in the description.

@laurentsimon
Copy link
Contributor

laurentsimon commented Feb 15, 2023

We currently only have main released for it

these test will need to be updated in the follow-up PR that enforces validation of the builder tag, correct?

@asraa
Copy link
Contributor Author

asraa commented Feb 15, 2023

these test will need to be updated in the follow-up PR, correct?

Yes! Right now this unblocks us from using verify in the e2e package repo though, so that's the idea. Without that we can't test @main and actually GA a release.

@asraa asraa enabled auto-merge (squash) February 15, 2023 20:43
@asraa asraa merged commit d8c2961 into slsa-framework:main Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants