ACME client support for standalone and webroot mode #122
Conversation
Codecov Report
@@ Coverage Diff @@
## master #122 +/- ##
==========================================
+ Coverage 68.37% 69.01% +0.63%
==========================================
Files 61 61
Lines 8349 8292 -57
==========================================
+ Hits 5709 5723 +14
+ Misses 2271 2201 -70
+ Partials 369 368 -1
Continue to review full report at Codecov.
|
command/ca/certificate.go
Outdated
| @@ -443,3 +486,408 @@ func parseTimeDuration(ctx *cli.Context) (notBefore api.TimeDuration, notAfter a | |||
| } | |||
| return | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Move everything after this to a new file.
There was a problem hiding this comment.
It might be even wiser to create a package with this functionality.
There was a problem hiding this comment.
For the time being I've moved everything acme related into one file under the command/ca package. Not sure about the benefit of creating a new package. Maybe that will become more clear when we need to add more functionality.
dopey
force-pushed
the
max/acme-standalone
branch
2 times, most recently
from
9f11571
to
56d1c6d
Compare
command/ca/token.go
Outdated
| @@ -490,6 +500,8 @@ func provisionerPrompt(ctx *cli.Context, provisioners provisioner.List) (provisi | |||
| return true | |||
| case provisioner.TypeGCP, provisioner.TypeAWS, provisioner.TypeAzure: | |||
| return true | |||
| case provisioner.TypeACME: | |||
| return ctx.Command.Name == "certificate" | |||
There was a problem hiding this comment.
Do we want to support step provisioner sign?
There was a problem hiding this comment.
assuming you mean step ca sign
dopey
force-pushed
the
max/acme-standalone
branch
from
ba21e78
to
07d0983
Compare
dopey
force-pushed
the
max/acme-standalone
branch
3 times, most recently
from
396a0be
to
d44aad4
Compare
dopey
force-pushed
the
max/acme-standalone
branch
from
d44aad4
to
1868ec3
Compare
Integrate with any ACME 2.0 server to get certificates using standalone or webroot mode.