Add URI capability to SplitSANs method #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maraino
requested changes
Jun 23, 2020
maraino
requested changes
Jun 25, 2020
command/ssh/certificate.go
Outdated
| template := &x509.CertificateRequest{ | ||
| Subject: csr.Subject, | ||
| DNSNames: csr.DNSNames, | ||
| IPAddresses: csr.IPAddresses, | ||
| EmailAddresses: csr.EmailAddresses, | ||
| URIs: []*url.URL{uri}, | ||
| URIs: append(csr.URIs, uri), |
There was a problem hiding this comment.
Prepend the generated uri. There is code that expects the uuid URI to be the first one.
| dnsNames = append(dnsNames, san) | ||
| } else { | ||
| uris = append(uris, u) | ||
| } |
There was a problem hiding this comment.
This is probably not strictly ok, but I think it is good enough.
There was a problem hiding this comment.
yeah, I wasn't sure what the right answer was. 🤷♂️ If / when people complain, we'll fix it.
go.mod
Outdated
| golang.org/x/sys v0.0.0-20200106162015-b016eb3dc98e | ||
| gopkg.in/square/go-jose.v2 v2.4.0 | ||
| howett.net/plist v0.0.0-20200419221736-3b63eb3a43b5 // indirect | ||
| ) | ||
|
|
||
| // replace github.com/smallstep/certificates => ../certificates | ||
| replace github.com/smallstep/certificates => ../certificates |
There was a problem hiding this comment.
Make sure to change this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.