Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 1st person for short usage #40

Merged
merged 1 commit into from
Nov 28, 2018
Merged

Use 1st person for short usage #40

merged 1 commit into from
Nov 28, 2018

Conversation

maraino
Copy link
Collaborator

@maraino maraino commented Nov 28, 2018

Description

Unify short usage to use the 1st person. Fixes #37

@codecov
Copy link

codecov bot commented Nov 28, 2018

Codecov Report

Merging #40 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #40   +/-   ##
=======================================
  Coverage   69.75%   69.75%           
=======================================
  Files          47       47           
  Lines        6533     6533           
=======================================
  Hits         4557     4557           
  Misses       1625     1625           
  Partials      351      351

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 482cfc0...e3e5cc1. Read the comment docs.

Copy link
Contributor

@sourishkrout sourishkrout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@maraino maraino merged commit b45df8d into master Nov 28, 2018
@maraino maraino deleted the first-person branch November 28, 2018 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants