-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check flag values before printing #449
Conversation
Codecov Report
@@ Coverage Diff @@
## master #449 +/- ##
=======================================
Coverage 63.29% 63.29%
=======================================
Files 57 57
Lines 6863 6863
=======================================
Hits 4344 4344
Misses 2280 2280
Partials 239 239 Continue to review full report at Codecov.
|
@maraino I've tested this out with various flag combos, seems to work well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but I would move that method to init.go.
I can also see if I can made ui.Println to support options so we can do things like
ui.Println("What's your name?", ui.WithValue(ctx.String("name"))
OK, I've addressed your feedback. The version with the options would be nice to have. If you want to do that, please add it. Or just approve and I'll merge :D |
No description provided.