Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check flag values before printing #449

Merged
merged 6 commits into from
Mar 22, 2021
Merged

Check flag values before printing #449

merged 6 commits into from
Mar 22, 2021

Conversation

tashian
Copy link
Contributor

@tashian tashian commented Mar 22, 2021

No description provided.

@codecov
Copy link

codecov bot commented Mar 22, 2021

Codecov Report

Merging #449 (fe7b030) into master (dfee1c4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #449   +/-   ##
=======================================
  Coverage   63.29%   63.29%           
=======================================
  Files          57       57           
  Lines        6863     6863           
=======================================
  Hits         4344     4344           
  Misses       2280     2280           
  Partials      239      239           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfee1c4...fe7b030. Read the comment docs.

@tashian tashian requested a review from maraino March 22, 2021 20:09
@tashian
Copy link
Contributor Author

tashian commented Mar 22, 2021

@maraino I've tested this out with various flag combos, seems to work well.

Copy link
Collaborator

@maraino maraino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I would move that method to init.go.

I can also see if I can made ui.Println to support options so we can do things like

ui.Println("What's your name?", ui.WithValue(ctx.String("name"))

ui/ui.go Outdated Show resolved Hide resolved
ui/ui.go Outdated Show resolved Hide resolved
@tashian
Copy link
Contributor Author

tashian commented Mar 22, 2021

OK, I've addressed your feedback. The version with the options would be nice to have. If you want to do that, please add it. Or just approve and I'll merge :D

@tashian tashian merged commit 7a89546 into master Mar 22, 2021
@tashian tashian deleted the ca-init-prompt branch March 22, 2021 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants