fix ReadCertPool function #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dopey
commented
Dec 12, 2018
dopey
commented
- document acceptable input
- don't fail if input is not either a file or directory
- trim space in comma delineated file list
* document acceptable input * don't fail if input is not either a file or directory * trim space in comma delineated file list
Codecov Report
@@ Coverage Diff @@
## master #46 +/- ##
=========================================
- Coverage 70.12% 70.1% -0.03%
=========================================
Files 47 47
Lines 6498 6500 +2
=========================================
Hits 4557 4557
- Misses 1590 1592 +2
Partials 351 351
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #46 +/- ##
=========================================
- Coverage 70.12% 70.1% -0.03%
=========================================
Files 47 47
Lines 6498 6500 +2
=========================================
Hits 4557 4557
- Misses 1590 1592 +2
Partials 351 351
Continue to review full report at Codecov.
|
maraino
requested changes
Dec 12, 2018
| if err != nil { | ||
| return nil, errors.WithStack(err) | ||
| if err != nil && !os.IsNotExist(err) { | ||
| return nil, errors.Wrapf(err, "os.Stat %s failed", path) |
There was a problem hiding this comment.
What happens if it's a not exists error? This snippet will show a nice error:
if err != nil {
return nil, errs.FileError(err, path)
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.