Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change dns to string slice in ca init but backwards compatible csv #545

Merged
merged 2 commits into from
Sep 9, 2021

Conversation

dopey
Copy link
Contributor

@dopey dopey commented Sep 9, 2021

Fixes #537

@dopey dopey requested a review from maraino September 9, 2021 07:00
@dopey dopey self-assigned this Sep 9, 2021
@github-actions github-actions bot added the needs triage Waiting for discussion / prioritization by team label Sep 9, 2021
Copy link
Collaborator

@maraino maraino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but can you remove the debug statement

dnsNames = append(dnsNames, strings.TrimSpace(name))
}

fmt.Printf("dnsNames = %+v\n", dnsNames)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove debug statement.

@dopey dopey merged commit 1fcd29e into master Sep 9, 2021
@dopey dopey deleted the max/dns branch September 9, 2021 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage Waiting for discussion / prioritization by team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ca init --dns=csv validated as single DNS name, not a CSV of them
2 participants