Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Describe revocation via JWK vs mTLS #594

Merged
merged 3 commits into from
Dec 8, 2021
Merged

Describe revocation via JWK vs mTLS #594

merged 3 commits into from
Dec 8, 2021

Conversation

tashian
Copy link
Contributor

@tashian tashian commented Dec 8, 2021

No description provided.

@tashian tashian requested a review from dopey December 8, 2021 20:30
@github-actions github-actions bot added the needs triage Waiting for discussion / prioritization by team label Dec 8, 2021
dopey
dopey reviewed Dec 8, 2021
View reviewed changes
command/ca/revoke.go Outdated Show resolved Hide resolved
dopey
dopey reviewed Dec 8, 2021
View reviewed changes
command/ca/revoke.go Outdated Show resolved Hide resolved
dopey
dopey requested changes Dec 8, 2021
View reviewed changes
Copy link
Contributor

@dopey dopey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left one comment where the documentation wasn't quite right. Otherwise lgtm

@tashian tashian merged commit 0e22d74 into master Dec 8, 2021
@tashian tashian deleted the revoke-usage branch December 8, 2021 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dopey dopey dopey requested changes

Assignees
No one assigned
Labels
needs triage Waiting for discussion / prioritization by team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tashian @dopey