step ca renew in offline mode should not require --ca-url and --root flags.
#629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ralf Henschkowski seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
github-actions
bot
added
the
needs triage
dopey
changed the title
step ca renew in offline mode should not require --ca-url and --root flags.
|
@henschkowski, thanks for the PR! Would you mind signing our CLA please? |
|
Signed it .
Max ***@***.***> schrieb am Mi., 9. Feb. 2022, 20:57:
… @henschkowski <https://github.com/henschkowski>, thanks for the PR! Would
you mind signing our CLA please?
—
Reply to this email directly, view it on GitHub
<#629 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACTD6FW3WG4T4UB76K2VLDU2LBJ5ANCNFSM5N4ZIB7Q>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
maraino
requested changes
Feb 9, 2022
There was a problem hiding this comment.
Hi @henschkowski, thanks for the PR, but can you change the condition.
| @@ -445,7 +445,8 @@ func ParseTemplateData(ctx *cli.Context) (json.RawMessage, error) { | |||
| // - Error if the URL scheme is not implicitly or explicitly 'https'. | |||
| func ParseCaURL(ctx *cli.Context) (string, error) { | |||
| caURL := ctx.String("ca-url") | |||
| if caURL == "" { | |||
| if caURL == "" && | |||
| !ctx.IsSet("offline") { | |||
There was a problem hiding this comment.
I would use !ctx.Bool("offline") because --offline=false is a valid option too.
|
Pulled this into another PR to fix the conflict which is from something else we recently merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #627.
I'm new to Go - this is my attempt to fix the issue.
💔Thank you!