Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all dependencies #186

Open
wants to merge 45 commits into
base: master
Choose a base branch
from
Open

Update all dependencies #186

wants to merge 45 commits into from

Conversation

WhoamiHF
Copy link
Collaborator

@WhoamiHF WhoamiHF commented Feb 17, 2024

  • compilation ok
  • login page loading ok
  • workspaces page loading ok
  • css not applied

TODO:

  • Bootstrap: Dropped form-specific layout classes for our grid system. Use our grid and utilities instead of .form-group, .form-row, or .form-inline. -> replace form-group with mb-3
    • We can possibly use mb-3 (margin bottom) from Bootstrap instead of custom withPadding
  • When there is an error in the panel, e.g., when I put a numeric signal instead of datetime in the linechart panel as time signal and the Elasticsearch queries fail, the panel keeps reloading over and over again. Previously, the plot just displayed "Error loading data." and the panel did not reload.
    • Apparently, the setFlashMessage method refreshes the page
  • In LineChart, shift+mouse wheel does not work (it should zoom the chart)... check the createChartZoom() method in TimeBasedChartBase
  • Histogram and Scatterplot don't work, but it is hard to debug with the panel reloading mentioned above. Ask Michal for more details after the reloading is resolved.
  • When I'm not logged in, and I open directly http://localhost:8080/workspaces/sample2, it should redirect me to the login page (http://localhost:8080/login?next=%2Fworkspaces%2Fsample2). Right now, it just crashes.
  • Figure out how to make the sidebar collapsable on mobile (see TODO in code in page.js)
  • Workspace name is missing in the breadcrumbs
  • When a panel is open, the sidebar should show other panels in the same workspace.
  • (@Mnaukal): check built-in templates
  • (@Mnaukal): check embedding
  • (@Mnaukal): check PDF export (see https://github.com/smartarch/ivis-core/wiki/PDF-export if it doesn't work)
  • check user creation
  • update SubRoute for the new router
  • update navigation blocking when form is not saved for the new router
    • This is probably not worth fixing now. It will require a major refactoring of the Section, SectionContent and RenderRoute components in page.js, because of changes in react-router@v6 (the useBlocker hook requires data API router which has a different schema for specifying the routes).
    • There might be a workaround or a library that I'm not aware of.
  • remove the debugging console.logs

This is not a new error (it was in the older version), but I just wanted to note it somewhere:

  • I think there is something slightly wrong with the permissions. When I open a panel, I should be able to edit its parameters... there should be an "Edit settings" button in the panel's settings (the gear icon in the top right-hand corner of the panel). However, the button only appears if the panel's template has "Elevated access" (and I think it should appear always as the "admin" should have the "edit" permission for the panel).

- updated dependencies
- fixed compilation warnings and errors on client
- fixed errors on the logging page in the browser and
- fixed logout
- fixed languages
@Mnaukal
Copy link
Collaborator

Mnaukal commented Feb 19, 2024

Check the browser developer tools to see whether the URL to the CSS files is correct (you don't want to see Failed to load resource: the server responded with a status of 404 (NOT FOUND)). I think the problem might again be in the configuration, you might need to copy parts of the www configuration section from production.yaml to developement.yaml (check if you have HTTPS enabled or not, it might be necessary to update trustedUrlBase to only have http:// without s).

If this doesn't help, I will try to install it on my machine and check.

Btw, there is no need to close and create a new pull request, you can just push to the extremeXP branch and the code of the PR updates.

WhoamiHF and others added 11 commits March 6, 2024 21:10
- problem with settings sidebar
- dubious ownership is because of chown in functions
- dealing with cors
- little bit improved styles
- fixed edit shown two times (and other problems with menu)
- removed types because of elastic search versions
- repaired bugs with modals (not possible to close, setting state of unmounted..)

In process:
Validation of any form fails when the values were not changed
@Mnaukal Mnaukal changed the title Problem with css Update all dependencies May 14, 2024
Copy link
Collaborator

@Mnaukal Mnaukal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahoj Davide, zběžně jsem prošel tvoje změny a narazil na pár drobností, kde si myslím, že by to chtělo trošku upravit. Někde jsi smazal části, které si myslím, že by měly zůstat zachované, ale to se vůbec nedivím, vzhledem k velikosti projektu vůbec je těžké všimnout si všeho. Díky.

client/package.json Outdated Show resolved Hide resolved
client/src/lib/i18n.js Outdated Show resolved Hide resolved
client/src/lib/modals.js Outdated Show resolved Hide resolved
server/index.js Outdated Show resolved Hide resolved
server/lib/indexers/elasticsearch-query.js Outdated Show resolved Hide resolved
server/lib/router-async.js Outdated Show resolved Hide resolved
server/routes/index.js Outdated Show resolved Hide resolved
server/views/layout.hbs Show resolved Hide resolved
WhoamiHF and others added 10 commits May 23, 2024 11:29
- renamed withTranslationCustom to withTranslation, resolved conflict
- removed cors artifacts
- returned trusted/sandbox tag

todo
- if in modals
- interval x fixed_interval in elasticsearch-query
- renamed withTranslationCustom to withTranslation, resolved conflict
- removed cors artifacts
- returned trusted/sandbox tag
- return if in modals
- changed fixed_interval to interval for number data in elasticsearch-query
Copy link
Collaborator

@Mnaukal Mnaukal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahoj Davide, povedlo se mi projít další část tvých změn. Narazil jsem tam na pár věcí, které ještě nejsou dodělané (zůstaly zakomentované). Většina z toho se týká routeru, tak jsem tě chtěl poprosit, jestli bys na to ještě mrknul, přeci jenom máš s tou novou verzí routeru trochu víc zkušeností, když už jsi nějaké úpravy dělal. Ale pokud vůbec netušíš, co s tím, tak to můžeme prostě sepsat do toho TODO v popisu pull requestu a pak nějak postupně vyřešit (já jsem mezitím některé z těch TODO vyřešil). Tak jen dej vědět, jestli se do těch dodělávek budeš pouštět nebo ne (třeba jako odpovědi na ty příslušné komentáře). Každopádně prioritu má tvorba docker kontejneru pro instalaci a základní verze API pro ExtremeXP, tohle klidně nech až potom. Díky.

client/src/lib/page-common.js Outdated Show resolved Hide resolved
client/src/workspaces/panels/WorkspacePanel.js Outdated Show resolved Hide resolved
client/src/root-trusted.js Outdated Show resolved Hide resolved
client/src/root-trusted.js Outdated Show resolved Hide resolved
client/src/lib/page.js Outdated Show resolved Hide resolved
client/src/lib/page-common.js Outdated Show resolved Hide resolved
client/src/lib/page.js Outdated Show resolved Hide resolved
client/src/lib/page.js Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants