Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TT-1273] besu start up cmd now works with 24.6.0 #991

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

Tofel
Copy link
Contributor

@Tofel Tofel commented Jun 14, 2024


Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.

Why

The changes improve the Besu Ethereum 2.0 client's container configuration by adding a new command option to disable bonsai limit trie logs for versions above 246. This adjustment addresses a known issue where the client crashes with sync-mode=FULL, ensuring smoother operation and compatibility with different sync modes required by consensus clients.

What

  • docker/test_env/besu_eth2.go
    • Modified the getEth2ContainerRequest function to dynamically construct the command array with essential configurations for running the Besu client within a container.
      • Added new command options for better control over the Besu client's operation, including data path, genesis file, network ID, host allowlist, RPC HTTP and WS configurations, engine JWT secret, and more.
      • Included a condition to append --bonsai-limit-trie-logs-enabled=false for Besu client versions above 246 to address a crash issue when using sync-mode=FULL.
    • Replaced the static command array previously used in the container request with the dynamically constructed cmd array.

@Tofel Tofel marked this pull request as ready for review June 14, 2024 11:10
@Tofel Tofel requested review from sebawo and a team as code owners June 14, 2024 11:10
@Tofel Tofel merged commit 03ceb82 into main Jun 14, 2024
27 checks passed
@Tofel Tofel deleted the tt_1273_update_besu_entrypoint branch June 14, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants