refactor sentry config #7757
Merged
refactor sentry config #7757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
jmank88
commented
Oct 25, 2022
| @@ -5,4 +5,4 @@ cd "$(dirname "$0")" | |||
| COMMIT_SHA=${COMMIT_SHA:-$(git rev-parse HEAD)} | |||
| VERSION=${VERSION:-$(cat "../../VERSION")} | |||
|
|
|||
| echo "-X github.com/smartcontractkit/chainlink/core/static.Version=$VERSION -X github.com/smartcontractkit/chainlink/core/static.Sha=$COMMIT_SHA -X github.com/smartcontractkit/chainlink/core/static.SentryDSN=$SENTRY_DSN" | |||
There was a problem hiding this comment.
static.SentryDSN actually doesn't exist 🤷
pinebit
previously approved these changes
Oct 25, 2022
pinebit
reviewed
Oct 25, 2022
jmank88
force-pushed
the
sc-23679-sentry-env
branch
from
50b2728
to
e584321
Compare
samsondav
previously requested changes
Oct 25, 2022
| sentryrelease = static.Version | ||
| } | ||
|
|
||
| return sentry.Init(sentry.ClientOptions{ |
There was a problem hiding this comment.
Uff, initialising global variable from application instance. In theory we could have multiple application instances, can you think of any way around this?
There was a problem hiding this comment.
In theory yes, but in implementation no, because we use an EmptyRunner in tests. Also, empirically, the gin stuff would have the same problem, but has been here over a year without flagging any races.
jmank88
requested review from
samsondav,
reductionista,
vyzaldysanchez and
bolekk
vyzaldysanchez
approved these changes
Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://app.shortcut.com/chainlinklabs/story/23679/prefix-all-env-vars-with-cl
Refactor sentry init to read from config instead of direct env vars.