-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.github/workflows: color golangci-lint xml with bat #9266
Conversation
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
dd028b5
to
0af7f96
Compare
SonarQube Quality Gate 0 Bugs No Coverage information |
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
SonarQube Quality Gate 0 Bugs No Coverage information |
@@ -88,9 +88,15 @@ jobs: | |||
only-new-issues: ${{ github.event.schedule == '' }} # show only new issues, unless it's a scheduled run | |||
allow-extra-out-format-args: true | |||
args: --out-format checkstyle:golangci-lint-report.xml | |||
- name: Install bat | |||
uses: awalsh128/cache-apt-pkgs-action@1850ee53f6e706525805321a3f2f863dcf73c962 # v1.3.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How much of an improvement does this give us over just reinstalling the package everytime? I'd like to keep our GHA deps low if we can.
Another route would be to install a dockerized version since I'd imagine this image already has docker
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't actually gotten it to work yet. IIRC I was just trying different approach of calling bat
, and had no luck. Feel free to push a new solution.
bat: command not found
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the stdout format is already colour coded, i'd specify it as an additional output instead. golangci/golangci-lint#2386
uses: awalsh128/cache-apt-pkgs-action@1850ee53f6e706525805321a3f2f863dcf73c962 # v1.3.0 | ||
with: | ||
packages: bat | ||
if: always() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we always pass? Seems like we'd want to fix this immediately if we didnt have access to reading reports
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
No description provided.