ipapi.com module #1138
Merged
ipapi.com module #1138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update - 30/9
Update master 16-01-2021
bcoles
reviewed
Jan 31, 2021
Co-authored-by: bcoles <bcoles@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #1138 +/- ##
==========================================
- Coverage 50.78% 50.76% -0.02%
==========================================
Files 442 444 +2
Lines 35777 35892 +115
==========================================
+ Hits 18168 18220 +52
- Misses 17609 17672 +63
Continue to review full report at Codecov.
|
smicallef
reviewed
Feb 9, 2021
|
|
||
| if self.opts['api_key'] == "": | ||
| self.sf.error("You enabled sfp_ipapicom but did not set an API key!") | ||
| self.errorState = True |
There was a problem hiding this comment.
errorState is set but not checked.
smicallef
reviewed
Feb 22, 2021
modules/sfp_ipapicom.py
Outdated
|
|
||
| if data.get('country_name'): | ||
| location = ', '.join(filter(None, [data.get('city'), data.get('region_name'), data.get('region_code'), data.get('country_name'), data.get('country_code')])) | ||
| location += f"\n-Latitude: {data.get('latitude')}\n-Longitude: {data.get('longitude')}" |
There was a problem hiding this comment.
Lat/Lon should be reported separately as PHYSICAL_COORDINATES.
smicallef
reviewed
Feb 22, 2021
modules/sfp_ipapicom.py
Outdated
| self.errorState = True | ||
| return None | ||
|
|
||
| if self.errorState: |
There was a problem hiding this comment.
This check should be before the above if block, since otherwise an error log will be generated for every event received.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.