Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requirements_test: Add pytest-xdist==2.2.1 #1178

Merged
merged 2 commits into from
Jun 12, 2021

Conversation

bcoles
Copy link
Contributor

@bcoles bcoles commented Jun 12, 2021

I've been using pytest-xdist locally for over a year to significantly speed up tests.

I forget if there was a reason we weren't already using this in requirements_test.txt for CI. Let's see if the tests pass.

@codecov-commenter
Copy link

codecov-commenter commented Jun 12, 2021

Codecov Report

Merging #1178 (5f6f65d) into master (90947fc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1178   +/-   ##
=======================================
  Coverage   50.19%   50.19%           
=======================================
  Files         456      456           
  Lines       36794    36794           
=======================================
  Hits        18470    18470           
  Misses      18324    18324           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90947fc...5f6f65d. Read the comment docs.

@bcoles
Copy link
Contributor Author

bcoles commented Jun 12, 2021

Ok tests pass. Let's try adding it to Travis.

@bcoles
Copy link
Contributor Author

bcoles commented Jun 12, 2021

The tests completed successfully, but only about 16 seconds faster. Compare:

pytest correctly identified that two processor cores were available, so I'm not sure why there wasn't much speed up, unless Travis was already performing some multi-core magic. It is also possible that Travis CI infrastructure issues caused discrepancies.

I suspect that over time we'll see a generally lower average completion time.

I see no harm in merging these changes in.

@smicallef smicallef merged commit 40177da into smicallef:master Jun 12, 2021
@bcoles bcoles deleted the requirements-test-xdist branch June 12, 2021 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants