Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a logging handler for SQLite and consolidates all logging activity into its own thread. This is accomplished with Python's built-in classes
logging.handlers.QueueHandler
andlogging.handlers.QueueListener
.Provided it is properly initialized, logging can now be performed anywhere without worrying about database locks, processes, or threads:
This PR is adapted directly from the official multiprocessing example in Python Logging Cookbook.
Logging code resides in a new file,
spiderfoot/logger.py
, which exposes functions for initializing logging in SpiderFoot.When the main process starts, logging is initialized like so. Note that
queue.Queue()
can be used instead ofmultiprocessing.Queue()
if multiprocessing is not in use.logWorkerSetup
is called once for each newmultiprocessing.Process()
that is spawned. Note that theloggingQueue
variable is passed into the new process.Functionally, the logging logic remains untouched except for one change. The SpiderFoot "root logger" has been changed from
logging.getLogger()
tologging.getLogger("spiderfoot")
. This was done to avoid unintentionally scooping up log messages from third-party libraries or clobbering the log settings of automation scripts that call SpiderFoot functions. If this is not a desired change, let me know and I can switch it back.