Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spiderfoot: store data and cache in user's home directory #1343

Merged
merged 1 commit into from
Sep 5, 2021

Conversation

bcoles
Copy link
Contributor

@bcoles bcoles commented Sep 5, 2021

This change is important.

It may lead to some initial confusion for anyone using the master branch. Short term pain for long term gain.

Your data is fine. Your data in spiderfoot.db is fine. It is still there.

The application is loading data from $HOME/.spiderfoot/spiderfoot.db now. (or $SPIDERFOOT_DATA/spiderfoot.db if you have the environment variable set.)

You can copy/move your old database from /path/to/spiderfoot/spiderfoot.db to $HOME/.spiderfoot/spiderfoot.db to restore all settings and scans.

@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2021

Codecov Report

Merging #1343 (e5e46e6) into master (ddc5cd8) will increase coverage by 0.02%.
The diff coverage is 68.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1343      +/-   ##
==========================================
+ Coverage   53.28%   53.31%   +0.02%     
==========================================
  Files         473      473              
  Lines       38677    38699      +22     
==========================================
+ Hits        20608    20631      +23     
+ Misses      18069    18068       -1     
Impacted Files Coverage Δ
test/unit/test_spiderfoot.py 97.73% <ø> (-0.02%) ⬇️
sf.py 53.37% <20.00%> (-0.50%) ⬇️
sflib.py 72.97% <100.00%> (+0.11%) ⬆️
spiderfoot/helpers.py 66.28% <100.00%> (+2.26%) ⬆️
test/conftest.py 100.00% <100.00%> (ø)
test/integration/test_sfwebui.py 95.93% <100.00%> (+0.02%) ⬆️
spiderfoot/event.py 100.00% <0.00%> (ø)
test/unit/spiderfoot/test_spiderfootevent.py 100.00% <0.00%> (ø)
modules/sfp_dnsresolve.py 50.44% <0.00%> (+0.44%) ⬆️
sfscan.py 84.00% <0.00%> (+1.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddc5cd8...e5e46e6. Read the comment docs.

@smicallef
Copy link
Owner

Should this include an update to .gitignore and .dockerignore?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants