Docker updates, fixes #1386
Merged
Docker updates, fixes #1386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1386 +/- ##
==========================================
- Coverage 52.73% 52.72% -0.01%
==========================================
Files 473 473
Lines 38853 38856 +3
==========================================
Hits 20488 20488
- Misses 18365 18368 +3
Continue to review full report at Codecov.
|
bcoles
reviewed
Sep 21, 2021
Dockerfile.full
Outdated
| # Configure tool paths | ||
| ENTRYPOINT python -c 'from spiderfoot import SpiderFootDb; \ | ||
| # Run the application | ||
| CMD python -c 'from spiderfoot import SpiderFootDb; \ | ||
| db = SpiderFootDb({"__database": "spiderfoot.db"}, init=True); \ |
There was a problem hiding this comment.
The __database key is supposed to represent the full file system path.
This should probably be:
Suggested change
| db = SpiderFootDb({"__database": "spiderfoot.db"}, init=True); \ | |
| db = SpiderFootDb({"__database": "/home/spiderfoot/.spiderfoot/spiderfoot.db"}, init=True); \ |
…erfoot into dockerfile-fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes in
Dockerfile.fulland updates todocker-compose.ymlto accommodate the new data location.