Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove modules' dependency on self.sf for logging #1461

Conversation

TheTechromancer
Copy link
Contributor

No description provided.

@TheTechromancer TheTechromancer marked this pull request as draft September 28, 2021 23:53
@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2021

Codecov Report

Merging #1461 (751515f) into master (1017041) will decrease coverage by 0.10%.
The diff coverage is 16.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1461      +/-   ##
==========================================
- Coverage   53.15%   53.05%   -0.11%     
==========================================
  Files         467      468       +1     
  Lines       38748    38905     +157     
==========================================
+ Hits        20597    20640      +43     
- Misses      18151    18265     +114     
Impacted Files Coverage Δ
modules/sfp_abusech.py 11.94% <0.00%> (ø)
modules/sfp_ahmia.py 23.45% <0.00%> (ø)
modules/sfp_alienvaultiprep.py 21.87% <0.00%> (ø)
modules/sfp_apple_itunes.py 20.79% <0.00%> (ø)
modules/sfp_archiveorg.py 25.60% <0.00%> (ø)
modules/sfp_azureblobstorage.py 25.00% <0.00%> (ø)
modules/sfp_blockchain.py 43.24% <0.00%> (ø)
modules/sfp_blocklistde.py 21.87% <0.00%> (ø)
modules/sfp_botvrij.py 25.00% <0.00%> (ø)
modules/sfp_cinsscore.py 22.09% <0.00%> (ø)
... and 215 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1017041...751515f. Read the comment docs.

@TheTechromancer TheTechromancer marked this pull request as ready for review September 29, 2021 00:24
@TheTechromancer TheTechromancer marked this pull request as draft September 29, 2021 14:28
@TheTechromancer TheTechromancer marked this pull request as ready for review September 30, 2021 14:04
@TheTechromancer TheTechromancer changed the title Remove modules' logging dependency on self.sf Remove modules' dependency on self.sf for logging Oct 1, 2021
@smicallef smicallef merged commit a34d8a8 into smicallef:master Oct 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants