sflib: Remove myPath() and move wordlist functions to SpiderFootHelpers #1687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1687 +/- ##
==========================================
+ Coverage 46.29% 46.31% +0.02%
==========================================
Files 707 707
Lines 46430 46467 +37
==========================================
+ Hits 21493 21522 +29
- Misses 24937 24945 +8
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
smicallef
reviewed
May 29, 2022
| @@ -61,7 +61,7 @@ def main() -> None: | |||
| '_fetchtimeout': 5, # number of seconds before giving up on a fetch | |||
| '_internettlds': 'https://publicsuffix.org/list/effective_tld_names.dat', | |||
| '_internettlds_cache': 72, | |||
| '_genericusers': "abuse,admin,billing,compliance,devnull,dns,ftp,hostmaster,inoc,ispfeedback,ispsupport,list-request,list,maildaemon,marketing,noc,no-reply,noreply,null,peering,peering-notify,peering-request,phish,phishing,postmaster,privacy,registrar,registry,root,routing-registry,rr,sales,security,spam,support,sysadmin,tech,undisclosed-recipients,unsubscribe,usenet,uucp,webmaster,www", | |||
| '_genericusers': ",".join(SpiderFootHelpers.usernamesFromWordlists(['generic-usernames'])), | |||
There was a problem hiding this comment.
Is the user overrides this in the UI, they will get lost the next time SpiderFoot is restarted, right?
There was a problem hiding this comment.
This behaviour is identical to the existing behaviour.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.